Skip to content

Fix python search path in emsdk launcher scripts #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jul 8, 2025

The -0 and -1 suffixes here are not part of the install path which only based on the id and version of the tool. e.g:

  {
    "id": "python",
    "version": "3.9.2",
    "bitness": 64,
    "arch": "x86_64",
    "windows_url": "python-3.9.2-1-embed-amd64+pywin32.zip",
    "activated_cfg": "PYTHON='%installation_dir%/python.exe'",
    "activated_env": "EMSDK_PYTHON=%installation_dir%/python.exe"
  },

Here we have a -1 in the archive name, but that is not included in the version which is used to construct the install path.

Fixes: #1570

The `-0` and `-1` suffixes here are not part of the install path which
only based on the `id` and `version` of the tool. e.g:

```
  {
    "id": "python",
    "version": "3.9.2",
    "bitness": 64,
    "arch": "x86_64",
    "windows_url": "python-3.9.2-1-embed-amd64+pywin32.zip",
    "activated_cfg": "PYTHON='%installation_dir%/python.exe'",
    "activated_env": "EMSDK_PYTHON=%installation_dir%/python.exe"
  },
```

Here we have a `-1` in the archive name, but that is not included
in the version which is used to construct the install path.

Fixes: #1570
@sbc100 sbc100 requested review from juj and dschuff July 8, 2025 15:06
@sbc100 sbc100 merged commit d845e50 into main Jul 10, 2025
12 checks passed
@sbc100 sbc100 deleted the fix_python_path branch July 10, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emsdk.bat uses the wrong python path
2 participants